Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: qs filter suggestions: example queries for multiple top attributes #5703

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Chore: qs filter suggestions: example queries for multiple top attributes #5703

merged 13 commits into from
Sep 9, 2024

Conversation

raj-k-singh
Copy link
Collaborator

Summary

Updates filter suggestion API to return example queries for multiple suggested attributes.
v0 returned an example query for only the first suggested attribute

Related Issues / PR's

Contributes to #5609

Screenshots

Before
Screenshot from 2024-08-15 20-03-07

After
Screenshot from 2024-08-15 20-00-35

Affected Areas and Manually Tested Areas

Logs Query Builder

@github-actions github-actions bot added the chore label Aug 15, 2024
@raj-k-singh raj-k-singh force-pushed the chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes branch 2 times, most recently from 9922cc6 to 1b3c363 Compare August 15, 2024 14:36
@raj-k-singh raj-k-singh force-pushed the chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes branch 2 times, most recently from 3bbfa76 to 4ae819b Compare September 3, 2024 14:06
@raj-k-singh
chore: put together helper for fetching values for multiple attributes
31da3ac
@raj-k-singh
chore: poc: use helper for filter suggestions
dc4464f
@raj-k-singh
chore: add a working impl for getting attrib values for multiple attr…
ff72637 
…ibutes
@raj-k-singh
chore: start updating integration test to account for new approach fo…
1288826 
…r getting log attrib values
@raj-k-singh
chore: use a global zap logger in filter suggestion tests
c084766
@raj-k-singh
chore: fix attrib values clickhouse query expectation
c8ab873
@raj-k-singh
chore: only query values for actual attributes when generating exampl…
18930d8 
…e queries
@raj-k-singh
chore: update clickhouse-go-mock
a3c2711
@raj-k-singh
chore: cleanup: separate params for attributesLimit and examplesLimit…
d4b0cf2 
… for filter suggestions
@raj-k-singh
chore: some test cleanup
0805e98
@raj-k-singh
chore: some more cleanup
550870a
@raj-k-singh
chore: some more cleanup
ae1fb55
@raj-k-singh raj-k-singh force-pushed the chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes branch from 340da51 to ae1fb55 Compare September 4, 2024 05:18
@raj-k-singh raj-k-singh marked this pull request as ready for review September 4, 2024 05:22
@raj-k-singh raj-k-singh merged commit 7844522 into develop Sep 9, 2024
12 checks passed
@raj-k-singh raj-k-singh deleted the chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes branch September 9, 2024 04:42
nityanandagohain
nityanandagohain approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while not a blocker/urgent thing, but can use cache in future since it's already available. With ttl of around half an hour for getValuesForLogAttributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raj-k-singh @srikanthccv @nityanandagohain